Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: disable recaptcha when site key is not set #5451

Merged
merged 3 commits into from
Feb 14, 2025

Conversation

mderynck
Copy link
Contributor

@mderynck mderynck commented Feb 13, 2025

What this PR does

Although recaptcha verification is disabled by default on the backend for OSS installs, the plugin was still making use of the site key and trying to load recaptcha. As that recaptcha site was removed this no longer works. The updated plugin code will skip recaptcha verification if it does not have a site key set.

Which issue(s) this PR closes

Related to #5449

Checklist

  • Unit, integration, and e2e (if applicable) tests updated
  • Documentation added (or pr:no public docs PR label added if not required)
  • Added the relevant release notes label (see labels prefixed w/ release:). These labels dictate how your PR will
    show up in the autogenerated release notes.

@mderynck mderynck requested a review from a team as a code owner February 13, 2025 17:24
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ mderynck
❌ actions-user
You have signed the CLA already but the status is still pending? Let us recheck it.

@mderynck mderynck changed the title Mderynck/disable oss recaptcha Disable recaptcha when site key is not set Feb 13, 2025
@mderynck mderynck added release:patch PR will be added to "Other Changes" section of release notes pr:no public docs Added to a PR that does not require public documentation updates labels Feb 13, 2025
@mderynck mderynck changed the title Disable recaptcha when site key is not set fix: disable recaptcha when site key is not set Feb 13, 2025
@mderynck mderynck added this pull request to the merge queue Feb 14, 2025
Merged via the queue into dev with commit cdb2946 Feb 14, 2025
25 of 29 checks passed
@mderynck mderynck deleted the mderynck/disable-oss-recaptcha branch February 14, 2025 14:41
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
pr:no public docs Added to a PR that does not require public documentation updates release:patch PR will be added to "Other Changes" section of release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants