-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Plugin E2E: Fix some APIs that were broken in older versions of Grafana #1391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
sunker
changed the title
[draft] Plugin E2E: Fix APIs in old versions of Grafana
[draft] Plugin E2E: Fix some APIs that were broken in older versions of Grafana
Dec 10, 2024
sunker
changed the title
[draft] Plugin E2E: Fix some APIs that were broken in older versions of Grafana
Plugin E2E: Fix some APIs that were broken in older versions of Grafana
Dec 10, 2024
sunker
added
patch
Increment the patch version when merged
release
Create a release when this pr is merged
labels
Dec 10, 2024
mckn
approved these changes
Dec 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Great work resolving this
🚀 PR was released in |
grafana-plugins-platform-bot
bot
added
the
released
This issue/pull request has been released.
label
Dec 11, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
While @mckn was working on this PR, he noticed some issues in older versions of Grafana. This PR fixes that.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
📦 Published PR as canary version:
Canary Versions
✨ Test out this PR locally via:
npm install @grafana/plugin-e2e@1.13.1-canary.1391.c64f458.0 # or yarn add @grafana/plugin-e2e@1.13.1-canary.1391.c64f458.0