Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Plugin E2E: Fix some APIs that were broken in older versions of Grafana #1391

Merged
merged 8 commits into from
Dec 11, 2024

Conversation

sunker
Copy link
Contributor

@sunker sunker commented Dec 10, 2024

What this PR does / why we need it:

While @mckn was working on this PR, he noticed some issues in older versions of Grafana. This PR fixes that.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

📦 Published PR as canary version: Canary Versions

✨ Test out this PR locally via:

npm install @grafana/plugin-e2e@1.13.1-canary.1391.c64f458.0
# or 
yarn add @grafana/plugin-e2e@1.13.1-canary.1391.c64f458.0

@sunker sunker requested a review from a team as a code owner December 10, 2024 15:39
@sunker sunker requested a review from academo December 10, 2024 15:39
Copy link

github-actions bot commented Dec 10, 2024

Hello! 👋 This repository uses Auto for releasing packages using PR labels.

✨ This PR can be merged and will trigger a new patch release.
NOTE: When merging a PR with the release label please avoid merging another PR. For further information see here.

@sunker sunker marked this pull request as draft December 10, 2024 16:32
@sunker sunker changed the title [draft] Plugin E2E: Fix APIs in old versions of Grafana [draft] Plugin E2E: Fix some APIs that were broken in older versions of Grafana Dec 10, 2024
@sunker sunker changed the title [draft] Plugin E2E: Fix some APIs that were broken in older versions of Grafana Plugin E2E: Fix some APIs that were broken in older versions of Grafana Dec 10, 2024
@sunker sunker added patch Increment the patch version when merged release Create a release when this pr is merged labels Dec 10, 2024
@sunker sunker requested a review from mckn December 10, 2024 18:04
@sunker sunker marked this pull request as ready for review December 10, 2024 18:04
Copy link
Collaborator

@mckn mckn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Great work resolving this

@sunker sunker merged commit c03938e into main Dec 11, 2024
21 checks passed
@sunker sunker deleted the plugin-e2e/fix-broken-scenarios branch December 11, 2024 07:22
@grafana-plugins-platform-bot
Copy link

🚀 PR was released in @grafana/plugin-e2e@1.13.1, @grafana/sign-plugin@3.0.5 🚀

@grafana-plugins-platform-bot grafana-plugins-platform-bot bot added the released This issue/pull request has been released. label Dec 11, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
patch Increment the patch version when merged release Create a release when this pr is merged released This issue/pull request has been released.
Projects
Development

Successfully merging this pull request may close these issues.

2 participants