Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Improve build and lint scripts #101

Merged
merged 3 commits into from
Oct 10, 2024
Merged

Improve build and lint scripts #101

merged 3 commits into from
Oct 10, 2024

Conversation

idastambuk
Copy link
Contributor

@idastambuk idastambuk commented Oct 7, 2024 •
edited
Loading

Looks like a lot, but the second commit is just prettier --write, so just the first commit can be selected and reviewed

  • adds lefthook for pre-commit
  • adds prettier
  • adds spellcheck
  • replaces typecheck with build step
  • rename build step to test-and-build

ivanahuckova
ivanahuckova approved these changes Oct 9, 2024
View reviewed changes
Copy link
Member

@ivanahuckova ivanahuckova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Great changes.

jest/.DS_Store Outdated Show resolved Hide resolved
@idastambuk idastambuk merged commit 8455837 into main Oct 10, 2024
2 checks passed
@idastambuk idastambuk deleted the build-ci branch October 10, 2024 09:09
@idastambuk idastambuk mentioned this pull request Nov 25, 2024
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@ivanahuckova ivanahuckova ivanahuckova approved these changes

@cletter7 cletter7 Awaiting requested review from cletter7

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@idastambuk @ivanahuckova