Update dependencies #165
Merged
Update dependencies #165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
andyasp
commented
Aug 12, 2024
| @@ -88,7 +88,7 @@ func NewCluster(ctx context.Context, t *testing.T, opts ...Option) Cluster { | |||
| }, | |||
| } | |||
|
|
|||
| clusterConfig, err := config.TransformSimpleToClusterConfig(ctx, runtimes.SelectedRuntime, simpleCfg) | |||
| clusterConfig, err := config.TransformSimpleToClusterConfig(ctx, runtimes.SelectedRuntime, simpleCfg, "") | |||
There was a problem hiding this comment.
"" is okay because the argument that was added is a file name which is only used if simpleCfg contained a non-empty Files field. Files is empty here.
andyasp
commented
Aug 12, 2024
| @@ -45,11 +45,11 @@ func newInstrumentedRouter(metrics *metrics) (*mux.Router, http.Handler) { | |||
| router := mux.NewRouter() | |||
|
|
|||
| httpMiddleware := []middleware.Interface{ | |||
| middleware.Tracer{ | |||
| middleware.RouteInjector{ | |||
There was a problem hiding this comment.
These changes are related to grafana/dskit#527
andyasp
force-pushed
the
aasp/update-dependencies
branch
from
6f87b99 to
9d2d183
Compare
56quarters
approved these changes
Aug 15, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's been a couple months so time for another fun dependency update. Still hoping one day to clear up the test dependencies.