-
Notifications
You must be signed in to change notification settings - Fork 21
chore: update fillform example to use async check #949
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think lo
is a suitable variable name in the context of being an example.
await check(page.locator('h2'), { | ||
header: async (lo) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would skip abbreviations in example code (with some exceptions).
I assume lo
is an abbreviation for "locator" (which resolves into an element-ish).
I suggest that we change lo
into element
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch! changed it 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🥇
The browser squad now recommends using the async
check
polyfill in all code examples and has updated thefillform
example in https://github.com/grafana/xk6-browser/tree/main/examplesIn order to be consistent, the
fillform
example for synthetics browser checks has been updated as well.