Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Cleanup operator instance metrics when instance is deleted #1019

Merged
merged 5 commits into from
Aug 27, 2024

Conversation

pavolloffay
Copy link
Collaborator

@pavolloffay pavolloffay commented Aug 27, 2024

https://issues.redhat.com/browse/TRACING-4609

Tested with

kubectl apply -f - <<EOF
apiVersion: tempo.grafana.com/v1alpha1
kind: TempoMonolithic
metadata:
  name: simplestmono
spec:
  storage:
    traces:
      backend: s3 
      size: 3Gi 
      s3: 
        secret: minio-test
EOF


kubectl apply -f - <<EOF
apiVersion: tempo.grafana.com/v1alpha1
kind: TempoStack
metadata:
  name: simplest
spec:
  storage:
    secret:
      name: minio-test
      type: s3
  storageSize: 1Gi
EOF

Then port-forward the operator 8080 and check for metric controller_runtime_reconcile_total

Signed-off-by: Pavol Loffay <p.loffay@gmail.com>
Signed-off-by: Pavol Loffay <p.loffay@gmail.com>
Signed-off-by: Pavol Loffay <p.loffay@gmail.com>
@codecov-commenter
Copy link

codecov-commenter commented Aug 27, 2024

Codecov Report

Attention: Patch coverage is 0% with 18 lines in your changes missing coverage. Please review.

Project coverage is 72.99%. Comparing base (e29848a) to head (26ef5d8).

Files Patch % Lines
internal/status/metrics.go 0.00% 8 Missing ⚠️
internal/webhooks/tempomonolithic_webhook.go 0.00% 5 Missing ⚠️
internal/webhooks/tempostack_webhook.go 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1019      +/-   ##
==========================================
- Coverage   73.16%   72.99%   -0.18%     
==========================================
  Files         106      106              
  Lines        6608     6624      +16     
==========================================
  Hits         4835     4835              
- Misses       1480     1496      +16     
  Partials      293      293              
Flag Coverage Δ
unittests 72.99% <0.00%> (-0.18%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Pavol Loffay <p.loffay@gmail.com>
Copy link
Collaborator

@andreasgerstmayr andreasgerstmayr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

Signed-off-by: Pavol Loffay <p.loffay@gmail.com>
@iblancasa iblancasa merged commit dd28af7 into grafana:main Aug 27, 2024
11 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants