-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Cleanup operator instance metrics when instance is deleted #1019
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1019 +/- ##
==========================================
- Coverage 73.16% 72.99% -0.18%
==========================================
Files 106 106
Lines 6608 6624 +16
==========================================
Hits 4835 4835
- Misses 1480 1496 +16
Partials 293 293
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm 👍
https://issues.redhat.com/browse/TRACING-4609
Tested with
Then port-forward the operator 8080 and check for metric
controller_runtime_reconcile_total