Do not add tracing CLI args to opa-openshift container #1081
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreasgerstmayr
force-pushed
the
fix-internal-tracing
branch
from
459c81b to
fd59843
Compare
The opa-openshift container does not support
`--internal.tracing.endpoint` and remains in a crashloop if
```
spec:
observability:
tracing:
jaeger_agent_endpoint: ...
sampling_fraction: "1"
```
is enabled.
Signed-off-by: Andreas Gerstmayr <agerstmayr@redhat.com>
andreasgerstmayr
force-pushed
the
fix-internal-tracing
branch
from
fd59843 to
da3e3d8
Compare
pavolloffay
approved these changes
Nov 4, 2024
|
Is there anything we need to do for the monolithic deployment? |
The monolithic deployment only supports ingestion via OTLP, but the internal Tempo instrumentation (currently) only supports exporting traces in Jaeger format. Therefore The next Tempo version supports OTLP, I plan to add support for the monolithic deployment then. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The opa-openshift container does not support
--internal.tracing.endpointand remains in a crashloop ifis enabled.