Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Bump gateway image to register missing Jaeger UI routes #1082

Merged

Conversation

andreasgerstmayr
Copy link
Collaborator

Update gateway image to include observatorium/api#781

Signed-off-by: Andreas Gerstmayr <agerstmayr@redhat.com>
@andreasgerstmayr andreasgerstmayr force-pushed the bump-observatorium-api-image branch from 0b0e12a to b32a6e2 Compare November 6, 2024 10:46
@codecov-commenter
Copy link

codecov-commenter commented Nov 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.91%. Comparing base (1ac621a) to head (8dd5884).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1082   +/-   ##
=======================================
  Coverage   67.91%   67.91%           
=======================================
  Files         110      110           
  Lines        8728     8728           
=======================================
  Hits         5928     5928           
  Misses       2503     2503           
  Partials      297      297           
Flag Coverage Δ
unittests 67.91% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

component: tempostack, tempomonolithic

# A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`).
note: Register missing Jaeger UI routes
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where are you implementing this? I only see some changes in manifest files.

Copy link
Collaborator Author

@andreasgerstmayr andreasgerstmayr Nov 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's implemented in observatorium/api#781, and this PR updates the image to use the latest version where this fix is included.

I thought it makes sense to copy the actual reason/fix to the operator changelog, versus just writing "bump gateway" in the operator changelog.

@andreasgerstmayr andreasgerstmayr merged commit 683d4b9 into grafana:main Nov 6, 2024
11 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants