-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Support multi-tenancy in TempoMonolithic CR #816
Support multi-tenancy in TempoMonolithic CR #816
Conversation
861bc61
to
3f1a6d0
Compare
3f1a6d0
to
1e694d4
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #816 +/- ##
==========================================
+ Coverage 74.26% 75.25% +0.99%
==========================================
Files 89 90 +1
Lines 6587 6932 +345
==========================================
+ Hits 4892 5217 +325
- Misses 1453 1463 +10
- Partials 242 252 +10
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
788050c
to
cc26d4f
Compare
cc26d4f
to
959dded
Compare
289fb57
to
da40700
Compare
1fdddba
to
1767cad
Compare
Signed-off-by: Andreas Gerstmayr <agerstmayr@redhat.com>
1767cad
to
7b67fa9
Compare
d2fc200
to
e0dcbe6
Compare
Signed-off-by: Andreas Gerstmayr <agerstmayr@redhat.com>
e0dcbe6
to
590ca4e
Compare
Signed-off-by: Andreas Gerstmayr <agerstmayr@redhat.com>
Signed-off-by: Andreas Gerstmayr <agerstmayr@redhat.com>
// The internal server is required because if the gateway is enabled, | ||
// the Tempo API will listen on localhost only, | ||
// and then Kubernetes cannot reach the health check endpoint. | ||
config.InternalServer.Enable = true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wondering if we cannot have the internal server always enabled? :D
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I think we should always enable it in the TempoStack
as well.
It is always enabled in TempoMonolithic
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small comment, no blocker LGTM!
Support multi-tenancy in TempoMonolithic CR.