Ingester Search honor ctx errors #3031
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdisibio
requested review from
joe-elliott,
annanay25,
mapno,
yvrhdn,
zalegrala,
electron0zero,
ie-pham and
stoewer
as code owners
joe-elliott
reviewed
Oct 18, 2023
| @@ -104,13 +116,21 @@ func (rw *Backend) CloseAppend(_ context.Context, tracker backend.AppendTracker) | |||
| return dst.Close() | |||
| } | |||
|
|
|||
| func (rw *Backend) Delete(_ context.Context, name string, keypath backend.KeyPath, _ bool) error { | |||
| func (rw *Backend) Delete(ctx context.Context, name string, keypath backend.KeyPath, _ bool) error { | |||
| if err := ctx.Err(); err != nil { | |||
There was a problem hiding this comment.
cc @zalegrala heads up you will want this context logic in the Blocks() method you added to the local backend
The local backend and wal block fixes should address them by catching the context error on the next i/o. But would appreciate another set of eyes. |
Good call. Agreed! |
joe-elliott
approved these changes
Oct 18, 2023
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Big queries sent to Ingester.SearchRecent may keep running after a context timeout. The root cause is the Local backend wraps local file i/o which is not context aware. This fixes the Local backend to check errors, but also addresses some handling in instance.Search to properly wait for all goroutines to complete before releasing the lock.
Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]