Tempo-query: improve performance of FindTraces #4159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavolloffay
force-pushed
the
tempo-query-find-traces-jobs
branch
from
ef236c1 to
1d25a2c
Compare
pavolloffay
requested review from
joe-elliott,
annanay25,
mdisibio,
mapno,
yvrhdn,
zalegrala,
electron0zero,
ie-pham and
stoewer
as code owners
pavolloffay
changed the title
6 tasks
andreasgerstmayr
approved these changes
Oct 4, 2024
zalegrala
reviewed
Oct 4, 2024
zalegrala
reviewed
Oct 4, 2024
zalegrala
reviewed
Oct 4, 2024
frzifus
reviewed
Oct 4, 2024
pavolloffay
force-pushed
the
tempo-query-find-traces-jobs
branch
from
c99ac19 to
1d25a2c
Compare
mdisibio
reviewed
Oct 8, 2024
mdisibio
approved these changes
Oct 8, 2024
Signed-off-by: Pavol Loffay <p.loffay@gmail.com>
pavolloffay
force-pushed
the
tempo-query-find-traces-jobs
branch
from
f1396e8 to
68b5f7c
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Improves performance for tempo query for searching traces. There is a new configuration option to submit multiple gettracebyid requests from a search.
Uses can scale up queriers and get faster queries. A single querier can process 20 queries https://grafana.com/docs/tempo/latest/operations/backend_search/#querier-and-query-frontend-configuration
Tested with TempoStack on OCP. Image
pavolloffay/tempo-query:concurrency-main-15Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]