This repository has been archived by the owner on Jan 30, 2025. It is now read-only.
Refactor isHidden to return an error #1109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ankur22
force-pushed
the
fix/isHidden
branch
from
d9a1d2c to
2fbeab6
Compare
inancgumus
approved these changes
Nov 23, 2023
ankur22
force-pushed
the
fix/isVisible
branch
2 times, most recently
from
9e1d3ed to
b971314
Compare
ankur22
force-pushed
the
fix/isHidden
branch
from
2fbeab6 to
e223239
Compare
ankur22
force-pushed
the
fix/isVisible
branch
2 times, most recently
from
be914dc to
317efca
Compare
This is for frame, elementHandle and page.
ankur22
force-pushed
the
fix/isHidden
branch
from
e223239 to
d65386f
Compare
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This refactors
isHiddenforlocator,page,frameandelementHandle.Why?
Returning an error is a safer way to work instead pf performing a panic which could have unexpected consequences.
Checklist
Related PR(s)/Issue(s)
Updates: grafana/k6#4403
Updates: #981