This repository has been archived by the owner on Jan 30, 2025. It is now read-only.
Fix dblClick #1121
Merged
Fix dblClick #1121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The up function in mouse shouldn't override the mouse and clickCount options. This is likely to have unwanted behaviour or missing behaviour
The behaviour of dblClick should comprise of: 1. Two pushes of a button which results in two clicks that can be recorded by a counter -- this behaviour was missing. 2. An onDblClick event which would result in any onDblClick listeners to be notified -- this behaviour already exists. This fix ensures that the click up and down action is performed multiple times based on the clickCount.
The mouse implementation of DblClick should work with the new fixed click method. The old dblClick method only resolves one of the two behaviours that are required (the counter will increase but the onDblClick event will not fire).
This will help ensure that the DblClick behaviour matches the two separate behaviours.
inancgumus
approved these changes
Dec 6, 2023
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes the behaviour of the
dblClickAPI calls fromlocator,page,elementHandleandframe(they all share the same logic which is implemented inmouse).Why?
When a
dblClickAPI call is made, it needs to perform two things:onDblClickevent is initiated and any listeners receive the event. This was already part of the implementation.Checklist
Related PR(s)/Issue(s)
Playwright reference: https://github.com/microsoft/playwright/blob/main/packages/playwright-core/src/server/input.ts#L199-L219
Updates: #469