Skip to content
This repository has been archived by the owner on Jan 30, 2025. It is now read-only.

Reupdate chrome not installed errs #1145

Merged
merged 1 commit into from
Jan 8, 2024
Merged

Conversation

inancgumus
Copy link
Member

What?

Changes the Chrome/Chromium not installed error messages.

Why?

To make the errors clearer (applied as per @heitortsergent's request).

Checklist

  • I have performed a self-review of my code
  • I have added tests for my changes
  • I have commented on my code, particularly in hard-to-understand areas

Related PR(s)/Issue(s)

Updates: #1136

@inancgumus inancgumus force-pushed the update/chrome-not-found-err2 branch from 3f4b861 to db7bd26 Compare December 21, 2023 09:59
@inancgumus inancgumus changed the title Change chrome not installed errs Reupdate chrome not installed errs Dec 21, 2023
Copy link

@heitortsergent heitortsergent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating the error message (and sorry I missed the first PR)! 🙇

Copy link
Collaborator

@ka3de ka3de left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@inancgumus inancgumus merged commit a224e27 into main Jan 8, 2024
17 checks passed
@inancgumus inancgumus deleted the update/chrome-not-found-err2 branch January 8, 2024 08:55
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants