Refactor parseConsoleRemoteObject to return error #1166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ankur22
force-pushed
the
refactor/parseConsoleRemoteObject
branch
from
868b1bc to
7302c41
Compare
ankur22
force-pushed
the
refactor/parseConsoleRemoteObject
branch
2 times, most recently
from
3d38886 to
8d48cf6
Compare
inancgumus
reviewed
Jan 25, 2024
ankur22
force-pushed
the
refactor/parseConsoleRemoteObject
branch
from
8d48cf6 to
fc47e2e
Compare
inancgumus
reviewed
Jan 29, 2024
inancgumus
previously approved these changes
Jan 29, 2024
There is another use case for parseConsoleRemoteObject, which is when JSONValue is called. At the moment this API uses valueFromRemoteObject which returns a goja.Value. Interestingly, the return value is always converted to string before being returned to the caller, so the extra step to convert to goja and then back to string is not needed.
ankur22
force-pushed
the
refactor/parseConsoleRemoteObject
branch
from
b0f41e7 to
5aedac1
Compare
inancgumus
approved these changes
Jan 29, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Returning an error from
parseConsoleRemoteObjectinstead of logging an error.Why?
There is another use case for
parseConsoleRemoteObject, which is whenJSONValueis called. At the moment this API usesvalueFromRemoteObjectwhich returns agoja.Value.Interestingly, the return value from
JSONValueis always converted to string before being returned to the caller, so the extra step to convert to goja and then back to string is not needed.Checklist
Related PR(s)/Issue(s)
Updates: #1168