This repository has been archived by the owner on Jan 30, 2025. It is now read-only.
Split mappings to prepare for async migration #1298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inancgumus
force-pushed
the
refactor/split-mappings
branch
from
716c52e to
e94b234
Compare
Closed
inancgumus
changed the title
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Splitting the component mappings from a single file into separate files.
Why?
While working on the sync-to-async migration (#428), this refactoring has the following benefits:
ElementHandle,Page, etc.) (less merging problems).main-async(a possible branch name) intomain, which might bring other merge conflicts if we can't deliver the work in a single cycle.Checklist
Related PR(s)/Issue(s)
#428