Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Prepare Mouse for async migration #1322

Merged
merged 7 commits into from
May 9, 2024
Merged

Prepare Mouse for async migration #1322

merged 7 commits into from
May 9, 2024

Conversation

inancgumus
Copy link
Member

What?

Maps the forgotten Mouse and turns panics into errors.

Why?

To make the async migration.

Checklist

  • I have performed a self-review of my code
  • I have added tests for my changes
  • I have commented on my code, particularly in hard-to-understand areas

Related PR(s)/Issue(s)

#1306

@inancgumus inancgumus added refactor async supports async (promises) stability runtime stability improvements labels May 9, 2024
@inancgumus inancgumus self-assigned this May 9, 2024
@inancgumus inancgumus marked this pull request as ready for review May 9, 2024 13:07
@inancgumus inancgumus requested a review from ankur22 May 9, 2024 13:07
@inancgumus inancgumus mentioned this pull request May 9, 2024
Closed
@inancgumus inancgumus changed the title Async mouse prepare Prepare Mouse for async migration May 9, 2024
@inancgumus inancgumus force-pushed the async/mouse-prepare branch from f0bb347 to 97006d4 Compare May 9, 2024 13:13
ankur22
ankur22 approved these changes May 9, 2024
View reviewed changes
Copy link
Collaborator

@ankur22 ankur22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@inancgumus inancgumus merged commit d10227f into main-async May 9, 2024
14 checks passed
@inancgumus inancgumus deleted the async/mouse-prepare branch May 9, 2024 14:51
@BrewTestBot BrewTestBot mentioned this pull request Jun 25, 2024
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@ankur22 ankur22 ankur22 approved these changes

Assignees

@inancgumus inancgumus

Labels
async supports async (promises) refactor stability runtime stability improvements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@inancgumus @ankur22