Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Async request #1348

Merged
merged 6 commits into from
May 28, 2024
Merged

Async request #1348

merged 6 commits into from
May 28, 2024

Conversation

ankur22
Copy link
Collaborator

@ankur22 ankur22 commented May 24, 2024 •
edited
Loading

What?

#1308.

Why?

See #428.

Checklist

  • I have performed a self-review of my code
  • I have added tests for my changes
  • I have commented on my code, particularly in hard-to-understand areas

Related PR(s)/Issue(s)

@ankur22 ankur22 changed the base branch from main to main-async May 24, 2024 14:47
@ankur22 ankur22 requested a review from inancgumus May 24, 2024 14:47
@inancgumus inancgumus mentioned this pull request May 27, 2024
Closed
inancgumus
inancgumus approved these changes May 27, 2024
View reviewed changes
Copy link
Member

@inancgumus inancgumus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ankur22 ankur22 merged commit 2a09dc1 into main-async May 28, 2024
17 checks passed
@ankur22 ankur22 deleted the async-request branch May 28, 2024 08:10
@BrewTestBot BrewTestBot mentioned this pull request Jun 25, 2024
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@inancgumus inancgumus inancgumus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ankur22 @inancgumus