Skip to content
This repository was archived by the owner on Jan 30, 2025. It is now read-only.

Enhance waitForSelector JavaScript error message #1462

Merged
merged 1 commit into from
Oct 7, 2024

Conversation

inancgumus
Copy link
Member

What and Why

See #1461 for details.

Checklist

  • I have performed a self-review of my code
  • I have added tests for my changes
  • I have commented on my code, particularly in hard-to-understand areas

Related PR(s)/Issue(s)

#1461

Sorry, something went wrong.

Copy link
Collaborator

@ankur22 ankur22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@inancgumus inancgumus force-pushed the enhance/waitForSelectorJS branch from 5d5a56f to 9e85606 Compare October 7, 2024 15:01
waitForSelector may result in a confusing error message:

        selector did not resolve to any element

We're now explaining which selector didn't resolve to an element.
@inancgumus inancgumus force-pushed the enhance/waitForSelectorJS branch from 9e85606 to cb45b1b Compare October 7, 2024 15:45
@inancgumus inancgumus merged commit b364519 into main Oct 7, 2024
20 checks passed
@inancgumus inancgumus deleted the enhance/waitForSelectorJS branch October 7, 2024 15:58
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants