Skip to content
This repository has been archived by the owner on Jan 30, 2025. It is now read-only.

Desobekify BrowserContext methods #1504

Merged
merged 6 commits into from
Nov 5, 2024
Merged

Desobekify BrowserContext methods #1504

merged 6 commits into from
Nov 5, 2024

Conversation

inancgumus
Copy link
Member

What?

See #1270.

Checklist

  • I have performed a self-review of my code
  • I have added tests for my changes
  • I have commented on my code, particularly in hard-to-understand areas

Related PR(s)/Issue(s)

Updates #1270

@inancgumus inancgumus added mapping k6 browser to Goja mapping related. stability runtime stability improvements labels Nov 4, 2024
@inancgumus inancgumus self-assigned this Nov 4, 2024
@inancgumus inancgumus marked this pull request as ready for review November 4, 2024 15:57
@inancgumus inancgumus requested a review from ankur22 November 4, 2024 15:57
This was referenced Nov 4, 2024
Closed
Merged
ankur22
ankur22 approved these changes Nov 5, 2024
View reviewed changes
Copy link
Collaborator

@ankur22 ankur22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

common/browser_context_options.go Show resolved Hide resolved
@inancgumus inancgumus merged commit 44fa0c0 into main Nov 5, 2024
22 of 23 checks passed
@inancgumus inancgumus deleted the desobekify/browser-context branch November 5, 2024 17:28
@BrewTestBot BrewTestBot mentioned this pull request Jan 6, 2025
Merged
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Reviewers

@ankur22 ankur22 ankur22 approved these changes

Assignees

@inancgumus inancgumus

Labels
mapping k6 browser to Goja mapping related. stability runtime stability improvements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@inancgumus @ankur22