This repository has been archived by the owner on Jan 30, 2025. It is now read-only.
Desobekify Credentials
#1518
Merged
Desobekify Credentials
#1518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inancgumus
force-pushed
the
fix/test-keyboard-press-test-panic
branch
from
dd098ed to
17a865f
Compare
inancgumus
requested review from
olegbespalov and
joanlopez
and removed request for
a team
No need for this type to be a pointer.
inancgumus
force-pushed
the
desobekify/credentials
branch
from
6bc31ab to
964fda6
Compare
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Credentials.Credentialsinto a value type.Why?
See "Desobekifying Sobek transformation" at grafana/k6#4219.
Checklist
Related PR(s)/Issue(s)
BrowserContextmethods #1270