fix: send headers from .setHeaders to server #202
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting the request headers via the
setHeaders
method is broken.setHeaders
only accepted the typeHeaders
which is not a pure object, so destructuring it would not append the headers when callingfetch
. One option would be to restrict the type of headers toRecord<string, string>
. However, that doesn't seem like the direction this package is taking, so the only other option is to handle all possible cases, i.e.Headers
,string[][]
,Record<string, string>
andundefined
.The PR also fixes the expected type of input to the
setHeaders
method, so it matches the type ofRequestInit["headers"]
.Unfortunately, I wasn't able to meaningfully test the added transformation logic via unit tests. I'm open to suggestions here 🙂
closes #203