Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

feat: passthrough headers on exported request function #265

Merged
merged 1 commit into from
May 12, 2021
Merged

feat: passthrough headers on exported request function #265

merged 1 commit into from
May 12, 2021

Conversation

TJTorola
Copy link
Contributor

This will allow headers to be set on the exported request function.

@TJTorola TJTorola force-pushed the tj/passthrough-request-headers branch from b0da8f0 to c26e2ed Compare May 12, 2021 15:19
@TJTorola
feat: Passthrough headers on exported request function
3813408 
This will allow headers to be set on the exported request function.
@TJTorola TJTorola force-pushed the tj/passthrough-request-headers branch from c26e2ed to 3813408 Compare May 12, 2021 15:26
jasonkuhrt
jasonkuhrt approved these changes May 12, 2021
View reviewed changes
Copy link
Member

@jasonkuhrt jasonkuhrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ty LGTM!

I think we're at a point where structured arguments would be nice too. But that can be added later.

@jasonkuhrt jasonkuhrt changed the title Passthrough headers on exported request function feat: passthrough headers on exported request function May 12, 2021
@jasonkuhrt jasonkuhrt merged commit 8587e4d into graffle-js:master May 12, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@jasonkuhrt jasonkuhrt jasonkuhrt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TJTorola @jasonkuhrt