Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Dev update trace ci32 #79

Merged
merged 35 commits into from
Mar 8, 2024
Merged

Dev update trace ci32 #79

merged 35 commits into from
Mar 8, 2024

Conversation

luckyjim
Copy link
Contributor

from issue grand-mother/collab-issues#32

luckyjim added 29 commits January 23, 2024 10:47
@luckyjim
first update grand-mother/collab-issues#32
9e611a9
@luckyjim
Merge remote-tracking branch 'origin/73_dev_efield2voltage' into dev_…
fb4382f 
…update_trace_ci32
@luckyjim
simplify class name Handling3dTraces
d9637bd
@luckyjim
code review, rename, add doc
6f41cb8
@luckyjim
rename update
c7d928c
@luckyjim
fix bug
068053e
@luckyjim
refactoring test with pytest, in progress ...
c8a9a4e
@luckyjim
update test
e929a76
@luckyjim
format
f4054f6
@luckyjim
remove
25e7103
@luckyjim
update test hilbert t_max, v_max
945d80a
@luckyjim
read only one time files of directory with memory cache
4153beb
@luckyjim
update minor, test files missing for new version of GRANDROOT
59daee5
@luckyjim
just add flaf for plot
c6ec3e7
@luckyjim
add causal passband filter
6e6d49e
@luckyjim
rename function, clean user interface
a5e0ebb
@luckyjim
add snr estimation in interface
15962b5
@luckyjim
update doc
5a94c10
@luckyjim
update intro notebook and Handle3dTraces notebook, debuging
1abf7fb
@luckyjim
remove obsolet comment and add subtitle
d0d6f1a
@luckyjim
name correction typo
0e57bcf
@luckyjim
fix problem with ident pos_xyz and temporary fix with sampling freq
55e9826
@luckyjim
Merge branch '73_dev_for_merge' into dev_update_trace_ci32
af0b3f1
@luckyjim
use DataDirectory from root_tree to define trun and tshower, issue
36abef9 
grand-mother/collab-issues#32
@luckyjim
improve multi-event infos, grand-mother/collab-issues#32
078aa90
@luckyjim
fix small problem, update notebook, grand-mother/collab-issues#32
36f8db2
@luckyjim
Merge remote-tracking branch 'origin/dev_sim2root' into dev_update_tr…
ab4f131 
…ace_ci32
@luckyjim
quality code with sonarqub, update notebook
c77c32a
@luckyjim
Merge remote-tracking branch 'origin/dev_sim2root' into dev_update_tr…
0704422 
…ace_ci32
@luckyjim luckyjim requested a review from mjtueros February 21, 2024 16:38
@luckyjim luckyjim requested a review from lwpiotr February 21, 2024 16:38
@luckyjim
Copy link
Contributor Author

luckyjim commented Mar 4, 2024

hello @oma
This request was made 2 weeks ago, the event viewer updates made it possible to quickly see the problems in the DC2 pilot simulations, confirming their usefulness.
so why wait any longer to accept this update that you requested?

@lwpiotr
Copy link
Contributor

lwpiotr commented Mar 4, 2024

Sorry, I am too busy with other very urgent stuff to do the review. Please either request the review from someone else, or... wait.

mjtueros
mjtueros approved these changes Mar 8, 2024
View reviewed changes
Copy link
Contributor

@mjtueros mjtueros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I looked at the files with Jean-Marc, and all the changes are related to the event viewer.

@mjtueros mjtueros merged commit 6b16bda into dev_sim2root Mar 8, 2024
1 check failed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@mjtueros mjtueros mjtueros approved these changes

@lwpiotr lwpiotr Awaiting requested review from lwpiotr

Assignees

@grand-oma grand-oma

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@luckyjim @lwpiotr @mjtueros @grand-oma