Improve remote resource behavior #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@wadetandy heads up |
* Previously, we'd disallow all writes. Now we allow associating to an existing remote entity (only applies to `belongs_to). * Previously, we'd avoid links for remote resources. Now, we avoid link validation (because we can't validate a remote API), but still generate the links (you can of course always turn this off). * As part of the last point, improved foreign key inferrence. We usually infer FK via the model name, but for remote resources the model is OpenStruct so we should use the resource name instead.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
existing remote entity (only applies to `belongs_to).
validation (because we can't validate a remote API), but still generate
the links (you can of course always turn this off).
infer FK via the model name, but for remote resources the model is
OpenStruct so we should use the resource name instead.