Fix deprecated call in activerecord adapter #477
Conversation
| @@ -304,7 +304,7 @@ def destroy(model_instance) | |||
| end | |||
|
|
|||
| def close | |||
| ::ActiveRecord::Base.clear_active_connections! | |||
| ::ActiveRecord::Base.connection_handler.clear_active_connections! | |||
There was a problem hiding this comment.
if ActiveRecord.version > '7.2'
::ActiveRecord::Base.connection_handler.clear_active_connections!
else
::ActiveRecord::Base.clear_active_connections!
end
There was a problem hiding this comment.
Let's assume that not everyone would be able to upgrade to 7.2+ as fast as we need to do it ;)
There was a problem hiding this comment.
as a quick fix, in the meantime, we could use something like the following:
ActiveRecord::Base.class.delegate :clear_active_connections!, to: :connection_handler
somewhere in an initializer, or such.
There was a problem hiding this comment.
or a much cleaner version:
ActiveRecord::Base.define_singleton_method :clear_active_connections! do
connection_handler.clear_active_connections!
end
|
@nbarthel Mind making that change and updating the PR? I'll release a new version after that. I like the clarity of the first version @mihaimuntenas suggested. |
|
Fixed in #478 |
Deprecated call
::ActiveRecord::Base.clear_active_connections!has been moved to connection_handler.This was causing our app to fail in production on Rails 7.2.1.
Not sure how well 7.2.1 is supported yet. Perhaps more PRs to come.