fix: remove unneeded empty bytes from callhook data #745
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the way it worked up to now,
_data.length
would always be nonzero, so we were calling the callhooks always, even when transferring to an EOA! This removes those unnecessary emptyBytes (which were there just to keep the gateway similar to Arbitrum's gateway implementation), and now_data
on the L2 side will be the callhook data sent from L1, and therefore zero length if there is no callhook to call.