fix: Dynamic data sources hotfixes (#3851)

graphprotocol · Aug 16, 2022 · ba86fd6 · ba86fd6
1 parent 354f4ed
commit ba86fd6
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 12 deletions.
diff --git a/core/src/subgraph/instance_manager.rs b/core/src/subgraph/instance_manager.rs
@@ -4,7 +4,6 @@ use crate::subgraph::loader::load_dynamic_data_sources;
 use crate::subgraph::runner::SubgraphRunner;
 use crate::subgraph::SubgraphInstance;
 use graph::blockchain::block_stream::BlockStreamMetrics;
-use graph::blockchain::DataSource;
 use graph::blockchain::NodeCapabilities;
 use graph::blockchain::{Blockchain, DataSourceTemplate};
 use graph::blockchain::{BlockchainKind, TriggerFilter};
@@ -187,18 +186,15 @@ impl<S: SubgraphStore> SubgraphInstanceManager<S> {
             .await
             .context("Failed to resolve subgraph from IPFS")?;
 
+            // We cannot include static data sources in the map because a static data source and a
+            // template may have the same name in the manifest.
+            let ds_len = manifest.data_sources.len() as u32;
             let manifest_idx_and_name: Vec<(u32, String)> = manifest
-                .data_sources
+                .templates
                 .iter()
-                .map(|ds: &C::DataSource| ds.name().to_owned())
-                .chain(
-                    manifest
-                        .templates
-                        .iter()
-                        .map(|t: &C::DataSourceTemplate| t.name().to_owned()),
-                )
+                .map(|t: &C::DataSourceTemplate| t.name().to_owned())
                 .enumerate()
-                .map(|(idx, name)| (idx as u32, name))
+                .map(|(idx, name)| (ds_len + idx as u32, name))
                 .collect();
 
             let data_sources = load_dynamic_data_sources(

diff --git a/store/postgres/src/dynds/private.rs b/store/postgres/src/dynds/private.rs
@@ -96,7 +96,7 @@ impl DataSourcesTable {
             ))
             .load::<Tuple>(conn)?;
 
-        Ok(tuples
+        let mut dses: Vec<_> = tuples
             .into_iter()
             .map(|(block_range, manifest_idx, param, context)| {
                 let creation_block = match block_range.0 {
@@ -112,7 +112,10 @@ impl DataSourcesTable {
                     creation_block,
                 }
             })
-            .collect())
+            .collect();
+        dses.sort_by_key(|v| v.creation_block);
+
+        Ok(dses)
     }
 
     pub(crate) fn insert(