Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Expose expensive queries file as an option #3710

Conversation

kaiwetlesen
Copy link

This pull request replaces the defined constant with EXPENSIVE_QUERIES with a parameter of a similar name. It also adds documentation in the testament describing the functionality exposed with the expensive queries file. Logs into the information log which file is used.

@kaiwetlesen
Copy link
Author

Background

This PR came from my reviewing the graph-node code in order to determine the reason why graph-node does not respond to SIGTERM or other typical graceful exit signalling. I figure it'd be good to expose this potentially useful feature as a configurable parameter.

@azf20
Copy link
Contributor

azf20 commented Jul 14, 2022

Thanks @kaiwetlesen! @lutter interested in your thoughts on this one

Copy link
Collaborator

@lutter lutter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! At some point, we should rethink this whole mechanism, but that's independent of this PR

@lutter lutter merged commit 81f9bcd into graphprotocol:master Jul 28, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants