Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

common: add pagination support to allocation queries #1046

Merged
merged 1 commit into from
Nov 19, 2024

Conversation

dwerner
Copy link
Contributor

@dwerner dwerner commented Nov 18, 2024

No description provided.

@dwerner dwerner requested a review from fordN November 18, 2024 21:22
@dwerner dwerner force-pushed the bug/allocation-pagination-support branch 5 times, most recently from 45c17c9 to 092c539 Compare November 18, 2024 21:45
Copy link
Contributor

@fordN fordN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍

As follow on work we could explore generalizing this queryAllocations() function and reusing elsewhere since we use similar code in indexer-common/src/allocations/monitor.ts.

@fordN fordN linked an issue Nov 18, 2024 that may be closed by this pull request
@dwerner dwerner force-pushed the bug/allocation-pagination-support branch 3 times, most recently from 8e1b19e to 9a49d1f Compare November 19, 2024 17:21
@dwerner dwerner force-pushed the bug/allocation-pagination-support branch from 9a49d1f to 8b79234 Compare November 19, 2024 18:35
@dwerner dwerner merged commit 07c4aae into release-0.21.8 Nov 19, 2024
4 checks passed
@dwerner dwerner deleted the bug/allocation-pagination-support branch November 19, 2024 18:58
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
Status: 🚗 Merged
Development

Successfully merging this pull request may close these issues.

[BUG] indexer-agent allowing multiple allocations
2 participants