Indexer-agent, indexer-cli: indexing rules applied instantly #352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hopeyen
force-pushed
the
hope/local_rule_pick_up
branch
from
49d7bd8 to
e608ef8
Compare
hopeyen
changed the title
hopeyen
force-pushed
the
hope/local_rule_pick_up
branch
from
e608ef8 to
91ecee6
Compare
hopeyen
commented
Jan 26, 2022
fordN
reviewed
Jan 28, 2022
hopeyen
force-pushed
the
hope/local_rule_pick_up
branch
5 times, most recently
from
ff99fa8 to
12bd70d
Compare
hopeyen
force-pushed
the
hope/local_rule_pick_up
branch
from
12bd70d to
a943ec4
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, indexers find agents needing a few minutes before picking up rules, so a common practice was to restart indexer-agent after setting the rules.
This PR speeds up the frequency of checking indexing rules, and triggers
Reconcile Deploymentswithin 20 seconds of changing the rules. -> indexers would not need to restart the agent as often.Rebased to
ford/local-rule-by-gns