Skip to content

fix postData's operationName on http-post example #673

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 22, 2023
Merged

fix postData's operationName on http-post example #673

merged 1 commit into from
Jul 22, 2023

Conversation

qustavo
Copy link
Contributor

@qustavo qustavo commented Jul 20, 2023

As per graphql's documentation the field should be operationName[1]

1: https://github.com/graphql/graphql-over-http/blob/main/spec/GraphQLOverHTTP.md#post

@coveralls
Copy link

Coverage Status

coverage: 92.051%. remained the same when pulling f4d0f50 on qustavo:patch-1 into a974186 on graphql-go:master.

chris-ramon
chris-ramon approved these changes Jul 22, 2023
View reviewed changes
Copy link
Member

@chris-ramon chris-ramon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 – Thanks @qustavo

@chris-ramon chris-ramon merged commit 4ebf270 into graphql-go:master Jul 22, 2023
@qustavo qustavo deleted the patch-1 branch July 22, 2023 21:16
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@chris-ramon chris-ramon chris-ramon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@qustavo @coveralls @chris-ramon