feat: added json path features to GraphQLResponse #138
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bsara
force-pushed
the
response-json-path
branch
2 times, most recently
from
788d023 to
48f744f
Compare
bsara
changed the title
bsara
force-pushed
the
response-json-path
branch
from
48f744f to
21b1741
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds JsonPath features to
GraphQLResponse. See #136 for details.I wanted to ensure that this remained backward compatible, so I created new methods that would ensure there would be no breaking changes:
getAt(String, Class),getAt(String), andgetListAt(String, Class).I do believe that the implementations of
getandgetListcould be updated to support JsonPath without breaking backward compatibility. However, I wanted to err on the side of caution and I don't know what the preference of the maintainers would be either. I'm happy to make any needed changes as well.