Skip to content

Update DateTimeScalar with Custom Scalar specification, add new official specifiedByURL #84

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 24, 2022
Merged

Update DateTimeScalar with Custom Scalar specification, add new official specifiedByURL #84

merged 1 commit into from
Nov 24, 2022

Conversation

dondonz
Copy link
Member

@dondonz dondonz commented Nov 24, 2022 •
edited
Loading

Hot off the press, we have an official place for contributed Custom Scalar specifications! https://scalars.graphql.org/

And the very first specification is for DateTimeScalar https://scalars.graphql.org/andimarek/date-time

This PR:

  • Updates the DateTimeScalar to conform with the specification, to not allow negative 0 offset for time zone
  • Adds the link to the official custom scalar specification

Note that in the forthcoming graphql-java v20, the method to specify the URL will change to specifiedByURL.

@dondonz dondonz merged commit 5610166 into master Nov 24, 2022
@dondonz dondonz deleted the update-datetime-scalar-with-spec branch November 24, 2022 06:04
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@bbakerman bbakerman bbakerman approved these changes

@andimarek andimarek Awaiting requested review from andimarek

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dondonz @bbakerman