Skip to content

WIP: feat: Add contains_exactly filter #391

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Open
wants to merge 2 commits into
base: add-filters
Choose a base branch
from

Conversation

sabard
Copy link
Collaborator

@sabard sabard commented Apr 24, 2023

The contains_exactly filter implements relational division, essentially finding entities related to those specified exactly by a search criteria. That is, found entities should have no relations not specified by the search criteria.

contains_exactly was not working with async sqlalchemy 1.4 and was holding up #357, so it was removed. This PR adds back the feature.

@codecov
Copy link

codecov bot commented Apr 24, 2023

Codecov Report

Attention: Patch coverage is 13.33333% with 13 lines in your changes missing coverage. Please review.

Project coverage is 93.13%. Comparing base (a03a8b1) to head (736f10d).
Report is 116 commits behind head on add-filters.

Files Patch % Lines
graphene_sqlalchemy/filters.py 13.33% 13 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##           add-filters     #391      +/-   ##
===============================================
- Coverage        96.37%   93.13%   -3.25%     
===============================================
  Files                9       10       +1     
  Lines              773     1296     +523     
===============================================
+ Hits               745     1207     +462     
- Misses              28       89      +61     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant