Benchmark: replace shell scripts with JS code #1470
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IvanGoncharov
force-pushed
the
cleanupBenchmark
branch
from
4453767 to
cb5d725
Compare
|
I don't think I have enough context around what we're doing with the benchmarks to give this a proper review. @leebyron might be needed here. |
mjmahone
approved these changes
Aug 24, 2018
There was a problem hiding this comment.
Just to make sure my review is accurate, I'd like to make sure I understand how the benchmark runner works.
We provide two revisions to compare against. Then we run all the benchmark tests to run, and run them one at a time using runBenchmark.
Given that understanding, this looks good.
IvanGoncharov
force-pushed
the
cleanupBenchmark
branch
from
cb5d725 to
7eb199f
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to have a better discussion around #1463 we need to add benchmarks for
validateandvalidateSDL. I split out refactoring part into this PR.@mjmahone Can you please take a look?