RFC: Schema Coordinates #3807
Open
RFC: Schema Coordinates #3807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for compassionate-pike-271cb3 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Hi @yaacovCR, I'm @github-actions bot happy to help you with this PR 👋 Supported commandsPlease post this commands in separate comments and only one per comment:
|
yaacovCR
force-pushed
the
schema-coordinates-rebased
branch
from
08e459e to
3945604
Compare
yaacovCR
added
spec RFC
This was referenced Dec 30, 2022
yaacovCR
force-pushed
the
schema-coordinates-rebased
branch
3 times, most recently
from
33c5916 to
1dafb51
Compare
yaacovCR
force-pushed
the
schema-coordinates-rebased
branch
2 times, most recently
from
e5ad1de to
75b9bd1
Compare
yaacovCR
force-pushed
the
schema-coordinates-rebased
branch
from
75b9bd1 to
0b41718
Compare
yaacovCR
force-pushed
the
schema-coordinates-rebased
branch
from
0b41718 to
934a631
Compare
yaacovCR
added a commit
to yaacovCR/graphql-js
that referenced
this pull request
Aug 22, 2024
extracted from graphql#3807
yaacovCR
added a commit
that referenced
this pull request
Sep 4, 2024
yaacovCR
force-pushed
the
schema-coordinates-rebased
branch
3 times, most recently
from
2c3466e to
923f6d3
Compare
yaacovCR
force-pushed
the
schema-coordinates-rebased
branch
from
923f6d3 to
8745736
Compare
Implements graphql/graphql-spec#794 Adds: * DOT punctuator in lexer * Improvements to lexer errors around misuse of `.` * Minor improvement to parser core which simplified this addition * `SchemaCoordinate` node and `isSchemaCoodinate()` predicate * Support in `print()` and `visit()` * Added function `parseSchemaCoordinate()` since it is a parser entry point. * Added function `resolveSchemaCoordinate()` and `resolveASTSchemaCoordinate()` which implement the semantics (name mirrored from `buildASTSchema`) as well as the return type `ResolvedSchemaElement`
yaacovCR
force-pushed
the
schema-coordinates-rebased
branch
from
8745736 to
9fc6c0b
Compare
yaacovCR
added a commit
that referenced
this pull request
Dec 1, 2024
…QLEnumValue (#4288) this extracts logic from #3044 and #3145 (later rebased as #3807 and #3808) to implement more informative error messages without implementing [the full schema coordinate RFC](graphql/graphql-spec#794) This is a BREAKING CHANGE because these schema elements are now longer plain objects and function differently in various scenarios, for example with `String(<schemaElement>` `JSON.stringifu(<schemaElement>` and `.toString()` and `.toJSON()` --------- Co-authored-by: Jovi De Croock <decroockjovi@gmail.com>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#3044 rebased on main.
@leebyron comments from original PR: