Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

polish(incremental): small fixes #4141

Merged
merged 3 commits into from
Jul 10, 2024
Merged

Conversation

yaacovCR
Copy link
Contributor

@yaacovCR yaacovCR commented Jul 9, 2024

to be added to main separately rather than squashed

@yaacovCR yaacovCR added the PR: polish 💅 PR doesn't change public API or any observed behaviour label Jul 9, 2024
@yaacovCR yaacovCR requested a review from robrichard July 9, 2024 11:59
@yaacovCR yaacovCR changed the base branch from 16.x.x to main July 9, 2024 11:59
@yaacovCR yaacovCR requested a review from a team as a code owner July 9, 2024 11:59
yaacovCR added 3 commits July 9, 2024 15:36
Use a stream that never resolves to better demonstrate how there will be a definite pending promise.

Calling return on the underlying graph flushes the nextQueue anyway.
Reduces the number of times we need to check as to whether to flush the next queue.
-- we do not need a formal iterator as we are the only consumer.
Copy link

netlify bot commented Jul 9, 2024

Deploy Preview for compassionate-pike-271cb3 ready!

Name Link
🔨 Latest commit 18d284c
🔍 Latest deploy log https://app.netlify.com/sites/compassionate-pike-271cb3/deploys/668d2f1dfff61f0008d2f7a5
😎 Deploy Preview https://deploy-preview-4141--compassionate-pike-271cb3.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@yaacovCR yaacovCR merged commit 5cd5001 into graphql:main Jul 10, 2024
20 checks passed
@yaacovCR yaacovCR deleted the small-fixes branch July 10, 2024 17:47
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
PR: polish 💅 PR doesn't change public API or any observed behaviour
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants