[WIP] adding 'subscription' language to GraphQL spec #109
Conversation
|
Are there any blockers on this PR? graphql-js now expects |
|
/cc @leebyron |
|
@taion I would presume that if there's a blocker at all, it's that subscription support in graphql-js is still experimental. Not sure how the GraphQL team wants to handle cases like that with the spec. |
|
Possibly just update the spec then? I think this is causing the Python guys some trouble with setting up the Relay babel plugin; specifically on running the packaged introspection query against a non-graphql-js server. |
| @@ -214,6 +215,19 @@ mutation { | |||
| } | |||
| ``` | |||
|
|
|||
| This subscription operation will retrieve the current number of likes and create | |||
There was a problem hiding this comment.
This bit is over-specified. A subscription doesn't have to do a retrieve then subscription, it probably only creates the subscription.
|
Adding the introspection bit is a good idea, but the actual execution of these subscription queries should be intentionally under-defined for now. The spec should make it clear that subscription queries are experimental in a note. |
|
@leebyron np and totally understood. I will update based on your comments. |
…hql-spec#109) and reference implementation. Closes #89
|
@skevy Any updates on this? We would like to implement subscriptions in Ruby but are waiting on an official spec and libgraphqlparser to do so. |
ghost
added
the
|
Closing in favor of #267 |
This PR adds language around the
subscriptionoperation type, which landed experimentally ingraphql-js@0.4.8, to the GraphQL specification.This is a WIP - there's still discussion to be had around subscriptions and what they mean for GraphQL, but I wanted to get the ball rolling on this so the can didn't get kicked too far down the road and also so that there was a place to discuss subscriptions in the context of the actual GraphQL specification.