Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Support gzip for session recording #1579

Closed
kontsevoy opened this issue Jan 12, 2018 · 1 comment
Closed

Support gzip for session recording #1579

kontsevoy opened this issue Jan 12, 2018 · 1 comment
Assignees
Labels
feature-request Used for new features in Teleport, improvements to current should be #enhancements

Comments

@kontsevoy
Copy link
Contributor

Problem

Currently Teleport stores session streams as-is, i.e. uncompressed. This creates unreasonable storage requirements for large organizations with many servers and users.

Proposal

Teleport should support two types of session files. Plain text (current implementation) and gzipped streams. The recorder must switch to always-gzipped mode, while the player should be able to read both plain text (for compatibility purposes). Early tests have shown that sessions with typical ansible/bash scripting over SSH get 20 times (!) smaller when gzipped.

Bonus Points

Also, when a file is closed and the session is over, can we also cryptographically sign it with Teleport CA's key and drop a signature file with the same name next to it? If we do this, tsh play should display a warning if the signature does not match.

@kontsevoy kontsevoy added the feature-request Used for new features in Teleport, improvements to current should be #enhancements label Jan 12, 2018
@kontsevoy kontsevoy added this to the 2.5.0 "New York" milestone Jan 12, 2018
@klizhentas
Copy link
Contributor

I would drop the signature/verify part - this is hard to get right with our RSA keys + there is key rotation to think about, etc, I think gzip is spot-on, but signatures - out of scope

klizhentas added a commit that referenced this issue Jan 15, 2018
Use gzip for session recordings, fixes #1579
@klizhentas klizhentas mentioned this issue Feb 19, 2018
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
feature-request Used for new features in Teleport, improvements to current should be #enhancements
Projects
None yet
Development

No branches or pull requests

3 participants