-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Add ReadPassword functionality to ContextReader #11436
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zmb3
reviewed
Mar 24, 2022
espadolini
previously approved these changes
Mar 25, 2022
espadolini
reviewed
Mar 25, 2022
prompt.Stdin() has the same behavior for non-abandoned reads.
80f560d
to
d103d60
Compare
d103d60
to
e37cf8c
Compare
PTAL @zmb3 @espadolini ? |
zmb3
approved these changes
Mar 25, 2022
PTAL? |
f0afb4f
to
2c89fa9
Compare
espadolini
approved these changes
Mar 25, 2022
2c89fa9
to
9fb0048
Compare
9fb0048
to
0ce2a5c
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes prompt.ContextReader in the following ways:
Turning clean reads into password reads is not supported. It's tricky and I have a few ideas, but it's not paramount at this moment.
This solves the woes caused by abandoned OTP reads followed by PIN reads in different packages, such as client.PromptMFAChallenge followed by
tsh mfa add
's implementation.#9160