Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Backport #12396 to branch/v9 #12423

Merged
merged 2 commits into from
May 4, 2022
Merged

Backport #12396 to branch/v9 #12423

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
29b3f3d
reduce verbosity of missing kernel support warning for secure symlink…
strideynet May 4, 2022
8db2eea
Merge branch 'branch/v9' into strideynet/v9/reduce-secure-symlink-log…
r0mant May 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions tool/tbot/botfs/fs_linux.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,10 +98,13 @@ func openSymlinksMode(path string, symlinksMode SymlinksMode) (*os.File, error)
case SymlinksTrySecure:
file, err = openSecure(path)
if err == unix.ENOSYS {
log.Warnf("Failed to write to %q securely due to missing "+
"syscall; falling back to regular file write. Set "+
"`symlinks: insecure` on this destination to disable this "+
"warning.", path)
missingSyscallWarning.Do(func() {
log.Warnf("Failed to write to %q securely due to missing "+
"syscall; falling back to regular file write. Set "+
"`symlinks: insecure` on this destination to disable this "+
"warning.", path)
})

file, err = openStandard(path)
if err != nil {
return nil, trace.Wrap(err)
Expand Down