[v9] Add nil check for billing mode in AWS DynamoDB events driver #12461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Check for nil in the billing mode getter + fix panic if eventtype is not set * use a better strategy to check if the interface is nil * add godoc * simplify switch * update godoc * simplify unknown field extraction code * ensure underlying type is correct * Update lib/events/dynamic_test.go Co-authored-by: Krzysztof Skrzętnicki <krzysztof.skrzetnicki@goteleport.com> * fix lint * Update AWS dynamo tests as a result of the dynamic.go changes, I don't think they've ever worked in some time as they appeared quite broke. * simplify * simplify 2 Co-authored-by: Krzysztof Skrzętnicki <krzysztof.skrzetnicki@goteleport.com>
Tener
reviewed
May 5, 2022
xacrimon
force-pushed
the
joel/v9/dynamo-ppd
branch
from
98cd30f to
3878abc
Compare
zmb3
approved these changes
May 5, 2022
Tener
approved these changes
May 5, 2022
Closed
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #12445