Client timeout fixes #12557
Merged
Client timeout fixes #12557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
espadolini
force-pushed
the
espadolini/client-timeouts
branch
2 times, most recently
from
6b1bf16 to
27fdfe5
Compare
espadolini
force-pushed
the
espadolini/client-timeouts
branch
from
27fdfe5 to
768e54e
Compare
codingllama
approved these changes
May 12, 2022
Sorry, I marked as ready for review and then got distracted 😅 |
Co-authored-by: Alan Parra <alan.parra@goteleport.com>
ravicious
approved these changes
May 13, 2022
|
@espadolini See the table below for backport results.
|
This was referenced May 13, 2022
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a couple of connectivity issues caused by either the lack of a timeout (in
api/client/webclient) or timeout settings being ignored in certain situations (inlib/utils/proxy).