Warn instead of hard error when validating u2f facets #12826
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ent domain or without https where required
codingllama
reviewed
May 23, 2022
|
@codingllama might be the best we can do, fixed |
espadolini
approved these changes
May 23, 2022
codingllama
approved these changes
May 23, 2022
Closed
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note, this will still hard error if the u2f facet is of a non URL format and cannot correctly be parsed but won't error on a differing domain or a missing https scheme.
Do we have a solid way to check for emitted log messages? A bit tricky to test now since we don't have a hard error to check.