Open a new remote client when the remote site has changed in a web session #13798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
espadolini
force-pushed
the
espadolini/reconnect-remotesite-web
branch
from
812dc86 to
c26a978
Compare
rosstimothy
approved these changes
Jun 23, 2022
atburke
approved these changes
Jun 28, 2022
espadolini
force-pushed
the
espadolini/reconnect-remotesite-web
branch
from
09ed1e0 to
64df629
Compare
|
/gcbrun |
|
@espadolini See the table below for backport results.
|
This was referenced Jun 29, 2022
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After #11435,
remoteSites are closed and removed from thereversetunnelserver, but web sessions keep a cache of the clients to remote clusters that they've used, and those clients use the auth dialer from theremoteSitethey were created from, resulting in a persistent in the web UI (fixable by logging out and back in or by waiting for the session to expire) when trying to reuse a remote cluster that has lost all tunnels to the proxy (because of an upgrade, a restart or just a transient network failure). This PR adds a secondary check on the session that discards the previous client and opens a new one if theremoteSiteis not the same.