Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Allow creation of multiple sessions per connection #1832

Merged
merged 1 commit into from
Apr 2, 2018

Conversation

russjones
Copy link
Contributor

Purpose

The in-memory forwarding server was incorrectly creating a "session" channel request for every connection upon accepting a client connection. The in-memory forwarding server has been updated to request a "session" channel when the client issues the request.

Implementation

  • Move the creation of the srv.ServerContext to when either the session or direct-tcpip channel request is being handled. This allows the creation of multiple sessions.
  • Moved connection closers out of srv.ServerContext and added them into forward.Server and are closed calling the Close method.
  • Cleaned up comments to bring them inline with current Teleport standards.

Related Issues

Fixes #1811

@russjones russjones requested a review from klizhentas March 30, 2018 22:50
@russjones russjones force-pushed the rjones/control-master branch 2 times, most recently from 1bc01e7 to ba46c05 Compare April 2, 2018 22:04
@russjones russjones force-pushed the rjones/control-master branch from ba46c05 to 9454d01 Compare April 2, 2018 22:11
@russjones russjones merged commit b4fad97 into master Apr 2, 2018
@russjones russjones deleted the rjones/control-master branch April 2, 2018 23:10
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ControlMaster can't be used with Recording Proxy
1 participant