Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

GCP CLI support: RBAC changes #19786

Merged
merged 4 commits into from
Jan 11, 2023
Merged

GCP CLI support: RBAC changes #19786

merged 4 commits into from
Jan 11, 2023

Conversation

Tener
Copy link
Contributor

@Tener Tener commented Jan 3, 2023

RBAC changes to recognize gcp_service_account trait as well as complementary allow/deny sections in roles. Required for #17257

To be applied on top of #19785.

@Tener Tener marked this pull request as ready for review January 3, 2023 11:50
Copy link
Contributor

@GavinFrazar GavinFrazar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

couple minor comments, but looks good

@github-actions github-actions bot removed the request for review from nklaassen January 4, 2023 10:21
@Tener Tener force-pushed the tener/gcloud-cli-api branch from ff5eceb to 3c637b1 Compare January 5, 2023 11:22
@Tener Tener force-pushed the tener/gcloud-cli-rbac branch 3 times, most recently from 3b523ed to 04028b9 Compare January 5, 2023 12:12
@Tener Tener force-pushed the tener/gcloud-cli-api branch from 3c637b1 to 8ad4596 Compare January 11, 2023 11:40
@Tener Tener force-pushed the tener/gcloud-cli-rbac branch from 04028b9 to c521c1a Compare January 11, 2023 11:40
Base automatically changed from tener/gcloud-cli-api to master January 11, 2023 12:21
@Tener Tener enabled auto-merge (squash) January 11, 2023 12:22
@Tener Tener merged commit d3a85ce into master Jan 11, 2023
@Tener Tener deleted the tener/gcloud-cli-rbac branch January 11, 2023 13:42
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants