Add GetUser to state.CachingAuthClient. #2020
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klizhentas
reviewed
Jun 20, 2018
lib/srv/authhandlers.go
Outdated
| @@ -335,18 +335,15 @@ func (h *AuthHandlers) fetchRoleSet(cert *ssh.Certificate, ca services.CertAutho | |||
| // for local users, go and check their individual permissions | |||
| var roles services.RoleSet | |||
| if clusterName == ca.GetClusterName() { | |||
| users, err := h.AccessPoint.GetUsers() | |||
| // Fetch user from cache. | |||
There was a problem hiding this comment.
the fact that it's a cache is implementation and configuration dependent, as far as the code is concerned, this is just a client point.
There was a problem hiding this comment.
(so remove the comment)
russjones
force-pushed
the
rjones/get-user
branch
from
90767fd to
1133b5e
Compare
access during login.
russjones
force-pushed
the
rjones/get-user
branch
from
1133b5e to
2ecc616
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
During login
GetUsersis called and iterated over to find theservices.Userthe user is trying to login as. This makes the login flow sensitive the number of users in the backend. Instead useGetUserget the exactservices.Userthe user is trying to login as.Implementation
GetUsertostate.CachingAuthClient.GetUserin the auth handler.Related Issues
Fixes #2021