Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

4.2 - Docs: Workflow Beta #3155

Merged
merged 6 commits into from
Dec 17, 2019
Merged

4.2 - Docs: Workflow Beta #3155

merged 6 commits into from
Dec 17, 2019

Conversation

benarent
Copy link
Contributor

This PR has been opened against a new 4.2-base branch to make reviewing easier. It outlines the new features for Workflows.

@benarent benarent added this to the 4.2 "Alameda" milestone Nov 13, 2019
@benarent benarent mentioned this pull request Nov 13, 2019
Closed
2 tasks
@benarent benarent changed the title Docs: Workflow Beta 4.2 - Docs: Workflow Beta Dec 3, 2019
@benarent benarent mentioned this pull request Dec 3, 2019
Closed
6 tasks
fspmarshall
fspmarshall reviewed Dec 3, 2019
View reviewed changes
Copy link
Contributor

@fspmarshall fspmarshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Points that came up during the final review of #3131 and should probably be documented:

  • The options.max_session_ttl field of the requested role (dba in your examples) provides an upper-limit on how long the access-request will be valid. If, for example, we wanted to ensure that contractor would need to re-request dba every hour, setting the options.max_session_ttl field of dba to 1 hour would be the correct way to do this.

  • Granting a role with administrative abilities could allow a user to permanently upgrade their privileges (e.g. if contractor was granted admin for some reason). This isn't particularly surprising, but it should be mentioned explicitly. The deny.request block can help mitigate the risk of doing this by accident.

@benarent benarent merged commit 7dbd755 into benarent/docs/4.2-base Dec 17, 2019
@benarent benarent deleted the benarent/docs/workflow branch December 17, 2019 21:59
webvictim
webvictim reviewed Dec 17, 2019
View reviewed changes
Copy link
Contributor

@webvictim webvictim left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I saw this late - some spelling/grammar nits.

I can re-add them on the final PR review if needed.

@benarent
Copy link
Contributor Author

Thanks Gus, I've gone ahead and fixed these.

benarent added a commit that referenced this pull request Dec 18, 2019
@benarent
4.2 Documentation Base (#3154)
46eefa1 
* Copy 4.1 -> 4.2 ( Documentation Base )
* 4.2 - Docs: Enhanced Session Recording (#3187)
* 4.2 - Docs:  GCP Backend Docs (#3191)
* 4.2 - Docs: Workflow Beta (#3155)
* CLI docs for remote tctl execution. #2991
* Expand logging into and set the default to disk.
* Fix any `milv` issues
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@webvictim webvictim webvictim left review comments

@fspmarshall fspmarshall fspmarshall left review comments

Assignees
No one assigned
Labels
documentation
Projects
None yet
Milestone
4.2 "Alameda"
Development

Successfully merging this pull request may close these issues.
4 participants
@benarent @klizhentas @webvictim @fspmarshall